Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix destructor for delayed mmap dataset case #6703

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Fix destructor for delayed mmap dataset case #6703

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec66e24
Fix destructor for delayed mmap dataset case
mikolajblaz May 23, 2023
de9c66a
Merge branch 'main' into mblaz/delayed-mmap-fix
ericharper Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion nemo/collections/nlp/data/language_modeling/megatron/indexed_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,8 @@ def _do_init(self, path, skip_warmup=True, delay_data_mmap=False):
self._create_data_mmap(skip_warmup)
else:
logging.info(" skip creating data numpy buffer of mmap...")
self._bin_buffer_mmap = None
self._bin_buffer = None

def _create_data_mmap(self, skip_warmup):
if not skip_warmup:
Expand All @@ -524,7 +526,8 @@ def _create_data_mmap(self, skip_warmup):
self._bin_buffer = memoryview(self._bin_buffer_mmap)

def __del__(self):
self._bin_buffer_mmap._mmap.close()
if self._bin_buffer_mmap is not None:
self._bin_buffer_mmap._mmap.close()
del self._bin_buffer_mmap
del self._index

Expand Down
Loading