[TTS] Fix adapter duration issue #6697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hsiehjackson <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
for more information, see https://pre-commit.ci
|
@hsiehjackson Can you also add the code to increase loss scale for aligner loss may be. We can add these two methods in the tutorial later. I feel the "increasing loss scale for aligner loss" should also be a good approach especially because that doesn't add parameters to finetune. |
Signed-off-by: hsiehjackson <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
for more information, see https://pre-commit.ci
@subhankar-ghosh Added |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
1 Minor issue, remaining LGTM. |
Signed-off-by: hsiehjackson <[email protected]>
…into fix_adapter_duration
hsiehjackson
added a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* Fix duration issue Signed-off-by: hsiehjackson <[email protected]> * Fix duration issue Signed-off-by: hsiehjackson <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add scale aligner loss Signed-off-by: hsiehjackson <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix bug Signed-off-by: hsiehjackson <[email protected]> --------- Signed-off-by: hsiehjackson <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fix TTS adapter duration issue.
Collection: [TTS]
Changelog
examples/tts/conf/fastpitch_align_44100_adapter.yamlexamples/tts/fastpitch_finetune_adapters.pynemo/collections/tts/losses/aligner_loss.pynemo/collections/tts/models/fastpitch.pytutorials/tts/FastPitch_Adapter_Finetuning.ipynbUsage
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information