Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all invalid tree references to blobs for NeMo samples #6679

Merged

Conversation

BrianMcBrayer
Copy link
Contributor

@BrianMcBrayer BrianMcBrayer commented May 19, 2023

Update all invalid tree references to blobs for NeMo samples

Currently, most of the TTS tutorials are "broken" because the link to colab is invalid. This fixes those links. I also verified that all the new links work correctly.

Collection: NeMo Tutorials

Changelog

  • Several of the tutorials pointed to an invalid git tree (should be blob). Updated to blob and verified they now work on colab

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests? (none needed)
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) (none)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

@BrianMcBrayer BrianMcBrayer force-pushed the update-all-colab-examples-to-blobs branch 3 times, most recently from 7405484 to 2360163 Compare May 19, 2023 01:27
The tree is invalid as this points to a blob, and the links would not
open in colab.

Signed-off-by: Brian McBrayer <[email protected]>
@BrianMcBrayer BrianMcBrayer force-pushed the update-all-colab-examples-to-blobs branch from 2360163 to d3c93a5 Compare May 19, 2023 01:29
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@titu1994 titu1994 merged commit ae87a40 into NVIDIA:main May 19, 2023
2 checks passed
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
…6679)

The tree is invalid as this points to a blob, and the links would not
open in colab.

Signed-off-by: Brian McBrayer <[email protected]>
Co-authored-by: Brian McBrayer <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants