Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exceptions with empty test / val ds config sections #6421

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

bmwshop
Copy link
Collaborator

@bmwshop bmwshop commented Apr 13, 2023

What does this PR do ?

Resolves exceptions when trying to train with empty test/ val ds config sections

Collection: ASR

Changelog

In nemo/utils/model_utils.py check if ds_values has values in it before trying to assign names to entries within. These names would have become visible in the test / validation sections of experiment manager (e.g. wandb) - but if these sections are emptty, there is no need to try.

Usage

  • You can potentially add a usage example below
# should no longer fail:
python asr_transducer/speech_to_text_rnnt_bpe.py --config-path=../conf/contextnet_rnnt/ --config-name=config_rnnt_bpe.yaml model.tokenizer.dir=data/tokenizer/tokenizer_bpe_v1024/ model.tokenizer.type="bpe" model.train_ds.manifest_filepath=data/LibriSpeech/train_clean_100.json model.train_ds.batch_size=32 model.joint.fuse_loss_wer=true model.joint.fused_batch_size=8 model.decoding.greedy.max_symbols=5 ~model.validation_ds +accelerator="gpu" +strategy="ddp" +devices=4 trainer.max_epochs=1 exp_manager.checkpoint_callback_params.monitor="train_loss" "

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • [X ] Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to bug 4067510

Signed-off-by: Dima Rekesh <[email protected]>
@bmwshop bmwshop requested a review from titu1994 April 13, 2023 01:15
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy, thanks for fixing this

@titu1994 titu1994 merged commit 801c646 into main Apr 13, 2023
@titu1994 titu1994 deleted the bug_4067510-a branch April 13, 2023 01:34
hsiehjackson pushed a commit that referenced this pull request Apr 13, 2023
Signed-off-by: Dima Rekesh <[email protected]>
hsiehjackson pushed a commit that referenced this pull request Apr 14, 2023
Signed-off-by: Dima Rekesh <[email protected]>
hsiehjackson pushed a commit that referenced this pull request Apr 14, 2023
Signed-off-by: Dima Rekesh <[email protected]>
hsiehjackson pushed a commit that referenced this pull request Apr 14, 2023
Signed-off-by: Dima Rekesh <[email protected]>
hsiehjackson pushed a commit that referenced this pull request Apr 14, 2023
Signed-off-by: Dima Rekesh <[email protected]>
hsiehjackson pushed a commit that referenced this pull request Apr 14, 2023
Signed-off-by: Dima Rekesh <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
hsiehjackson pushed a commit that referenced this pull request Apr 14, 2023
Signed-off-by: Dima Rekesh <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
hsiehjackson pushed a commit that referenced this pull request Apr 17, 2023
Signed-off-by: Dima Rekesh <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Signed-off-by: Dima Rekesh <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants