Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FastConformer config: correct bucketing strategy #6413

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Fix FastConformer config: correct bucketing strategy #6413

merged 1 commit into from
Apr 11, 2023

Conversation

artbataev
Copy link
Collaborator

@artbataev artbataev commented Apr 11, 2023 •
edited
Loading

What does this PR do ?

Fix typo in bucketing strategy in FastConformer configs.

Collection: [ASR]

Changelog

  • Add specific line by line info of high level changes in this PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@artbataev artbataev requested a review from bmwshop April 11, 2023 20:12
@github-actions github-actions bot added the ASR label Apr 11, 2023
titu1994
titu1994 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@titu1994 titu1994 merged commit 46eb4d7 into NVIDIA:main Apr 11, 2023
@bmwshop
Copy link
Collaborator

bmwshop commented Apr 12, 2023

ooh thank you!

hsiehjackson pushed a commit that referenced this pull request Apr 12, 2023
@artbataev @hsiehjackson
Fix FastConformer config: correct bucketing strategy (#6413)
021e5f5 
Signed-off-by: Vladimir Bataev <[email protected]>
@artbataev artbataev deleted the fix_fast_conformer_config_bucketing branch April 12, 2023 07:53
hsiehjackson pushed a commit that referenced this pull request Apr 14, 2023
@artbataev @hsiehjackson
Fix FastConformer config: correct bucketing strategy (#6413)
e2d3ead 
Signed-off-by: Vladimir Bataev <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
@artbataev @hsiehjackson
Fix FastConformer config: correct bucketing strategy (NVIDIA#6413)
ca82d43 
Signed-off-by: Vladimir Bataev <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titu1994 titu1994 titu1994 approved these changes

@bmwshop bmwshop Awaiting requested review from bmwshop

Assignees
No one assigned
Labels
ASR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artbataev @bmwshop @titu1994