Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prompt template unescaping #6399

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Fix prompt template unescaping #6399

merged 2 commits into from
Apr 10, 2023

Conversation

MaximumEntropy
Copy link
Contributor

What does this PR do ?

Unescape the prompt template to allow providing escape sequences in the prompt template from the CLI.

Collection: NLP

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: MaximumEntropy <[email protected]>
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 865bff9 into main Apr 10, 2023
@ericharper ericharper deleted the unescape_prompt_template branch April 10, 2023 17:04
hsiehjackson pushed a commit that referenced this pull request Apr 11, 2023
* Fix prompt template unescaping

Signed-off-by: MaximumEntropy <[email protected]>

* Fix for when prompt template is None

Signed-off-by: MaximumEntropy <[email protected]>

---------

Signed-off-by: MaximumEntropy <[email protected]>
hsiehjackson pushed a commit that referenced this pull request Apr 12, 2023
* Fix prompt template unescaping

Signed-off-by: MaximumEntropy <[email protected]>

* Fix for when prompt template is None

Signed-off-by: MaximumEntropy <[email protected]>

---------

Signed-off-by: MaximumEntropy <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* Fix prompt template unescaping

Signed-off-by: MaximumEntropy <[email protected]>

* Fix for when prompt template is None

Signed-off-by: MaximumEntropy <[email protected]>

---------

Signed-off-by: MaximumEntropy <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants