Add support for Megatron GPT Untied Embd TP PP Change #6388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smajumdar <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: smajumdar <[email protected]>
titu1994
force-pushed
the
gpt_untied_tppp
branch
from
ccfcd8a
to
f8355f7
Compare
…_dir Signed-off-by: smajumdar <[email protected]>
yidong72
approved these changes
Apr 11, 2023
hsiehjackson
pushed a commit
that referenced
this pull request
Apr 12, 2023
* Add support for Megatron GPT Untied Embd TP PP Change Signed-off-by: smajumdar <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add support for Megatron GPT Untied Embd TP PP Change Signed-off-by: smajumdar <[email protected]> * Update support for model_file to be None when passing model_extracted_dir Signed-off-by: smajumdar <[email protected]> --------- Signed-off-by: smajumdar <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* Add support for Megatron GPT Untied Embd TP PP Change Signed-off-by: smajumdar <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add support for Megatron GPT Untied Embd TP PP Change Signed-off-by: smajumdar <[email protected]> * Update support for model_file to be None when passing model_extracted_dir Signed-off-by: smajumdar <[email protected]> --------- Signed-off-by: smajumdar <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds support for untied embeddings for Megatron GPT for TP PP change
Collection: [NLP]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type: