-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update script for ngram rnnt and hat beam search decoding #6370
Merged
Merged
Changes from 20 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
5af82cf
add rnnt ngram beamsearch script
andrusenkoau 6a3fe03
Merge branch 'main' of https://github.com/andrusenkoau/NeMo into merg…
andrusenkoau b552e46
add return encoding embedding option
andrusenkoau aab62bc
update script
andrusenkoau 36992dc
add rnnt and hat ngram decoding script
andrusenkoau a791367
add some parameters
andrusenkoau 430d1b0
Merge branch 'main' of https://github.com/andrusenkoau/NeMo into ngra…
andrusenkoau 238fb25
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ac8c221
Merge branch 'main' of https://github.com/andrusenkoau/NeMo into ngra…
andrusenkoau 992ffcb
add return_encoder_embeddings parameter to RNNTDecodingConfig
andrusenkoau 8bd09b0
replace return_encoder_embeddings parameter
andrusenkoau 95fc4df
generalization of scipt behavior
andrusenkoau 8d5e926
resolve conflicts
andrusenkoau 2db619a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 24d34a1
Merge branch 'main' into ngram_rnnt
andrusenkoau 2e04f17
remove return_encoder_embeddings parameter
andrusenkoau 7afa9ef
remove return_encoder_embeddings parameter
andrusenkoau c2f0f6c
add manual encoder_embeddings calculation
andrusenkoau 49e64d6
Merge branch 'main' into ngram_rnnt
andrusenkoau d07f41f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 780769e
Merge branch 'main' into ngram_rnnt
andrusenkoau 80f4f61
Merge branch 'main' into ngram_rnnt
andrusenkoau 9267044
Merge branch 'main' into ngram_rnnt
titu1994 fcf2421
Merge branch 'main' into ngram_rnnt
andrusenkoau 64d17e4
fix beam_width value to 8
andrusenkoau df9b90e
fix rescoring description
andrusenkoau 503160e
Merge branch 'main' into ngram_rnnt
andrusenkoau a621d2b
Merge branch 'main' into ngram_rnnt
titu1994 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't user use rescoring with RNNT models?
The output of the beam search is a list of candiate which is independent of the type of the decoder. Then we pass this file to the rescorer, so the neural rescorer should support all ASR models?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, you are absolutely right. I forgot about rescoring of n-best results with NNLM. I meant that RNNT/HAT models do not support NNLM in shallow fusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I returned the old description