[NeMo Megatron] Cleanup configs to infer the models TP PP config automatically #6368

titu1994 · 2023-04-04T22:21:19Z

What does this PR do ?

Collection: [NLP]

Changelog

Update configs to set tp pp and pp rank all to -1
Check and update -1 to the model config results

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

Signed-off-by: smajumdar <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: smajumdar <[email protected]>

ericharper

LGTM. Thanks!

Signed-off-by: smajumdar <[email protected]>

…matically (NVIDIA#6368) * Try to make tp pp input size not required Signed-off-by: smajumdar <[email protected]> * Update configs for rest of models Signed-off-by: smajumdar <[email protected]> * Update remaining configs and scripts Signed-off-by: smajumdar <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Correct path for T5 Adapters / IA3 Signed-off-by: smajumdar <[email protected]> * Do safe get for older configs Signed-off-by: smajumdar <[email protected]> * Fix bug with config arg name Signed-off-by: smajumdar <[email protected]> --------- Signed-off-by: smajumdar <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: hsiehjackson <[email protected]>

github-actions bot added the NLP label Apr 4, 2023

titu1994 added 3 commits April 4, 2023 15:52

Try to make tp pp input size not required

0003849

Signed-off-by: smajumdar <[email protected]>

Update configs for rest of models

1481e55

Signed-off-by: smajumdar <[email protected]>

Update remaining configs and scripts

3de60cc

Signed-off-by: smajumdar <[email protected]>

titu1994 force-pushed the cleanup_scripts branch from 6a9bd02 to 3de60cc Compare April 4, 2023 22:53

pre-commit-ci bot and others added 2 commits April 4, 2023 22:54

[pre-commit.ci] auto fixes from pre-commit.com hooks

eca424e

for more information, see https://pre-commit.ci

Correct path for T5 Adapters / IA3

0011bb8

Signed-off-by: smajumdar <[email protected]>

ericharper previously approved these changes Apr 5, 2023

View reviewed changes

Do safe get for older configs

78ffaae

Signed-off-by: smajumdar <[email protected]>

titu1994 dismissed ericharper’s stale review via 78ffaae April 6, 2023 00:53

Fix bug with config arg name

ba62585

Signed-off-by: smajumdar <[email protected]>

titu1994 merged commit 3f8eec4 into NVIDIA:main Apr 6, 2023

titu1994 deleted the cleanup_scripts branch April 6, 2023 23:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NeMo Megatron] Cleanup configs to infer the models TP PP config automatically #6368

[NeMo Megatron] Cleanup configs to infer the models TP PP config automatically #6368

titu1994 commented Apr 4, 2023

ericharper left a comment

[NeMo Megatron] Cleanup configs to infer the models TP PP config automatically #6368

[NeMo Megatron] Cleanup configs to infer the models TP PP config automatically #6368

Conversation

titu1994 commented Apr 4, 2023

What does this PR do ?

Changelog

Before your PR is "Ready for review"

ericharper left a comment

Choose a reason for hiding this comment