Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs on the use of heterogeneous test / val manifests #6352

Merged
merged 2 commits into from
Apr 3, 2023
Merged

docs on the use of heterogeneous test / val manifests #6352

merged 2 commits into from
Apr 3, 2023

Conversation

bmwshop
Copy link
Collaborator

@bmwshop bmwshop commented Apr 3, 2023

What does this PR do ?

Adds docs for the use of multiple test / validation manifests as enabled in #6306

Collection: ASR

Changelog

  • Added docs to docs/source/asr/configs.rst

Usage

Docs only

# Add a code snippet demonstrating how to use this 
n/a

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • [ x] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@bmwshop
docs
7778a6b 
Signed-off-by: Dima Rekesh <[email protected]>
@github-actions github-actions bot added the ASR label Apr 3, 2023
@bmwshop bmwshop changed the title docs docs on the use of heterogeneous validation manifests Apr 3, 2023
@bmwshop bmwshop changed the title docs on the use of heterogeneous validation manifests docs on the use of heterogeneous test / val manifests Apr 3, 2023
@bmwshop
typo
667455e 
Signed-off-by: Dima Rekesh <[email protected]>
@bmwshop bmwshop requested a review from titu1994 April 3, 2023 16:38
titu1994
titu1994 approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@titu1994 titu1994 merged commit 8ffcb95 into main Apr 3, 2023
@titu1994 titu1994 deleted the multivaldocs branch April 3, 2023 16:40
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
@bmwshop @hsiehjackson
docs on the use of heterogeneous test / val manifests (NVIDIA#6352)
3314310 
* docs

Signed-off-by: Dima Rekesh <[email protected]>

* typo

Signed-off-by: Dima Rekesh <[email protected]>

---------

Signed-off-by: Dima Rekesh <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titu1994 titu1994 titu1994 approved these changes

Assignees
No one assigned
Labels
ASR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmwshop @titu1994