[Core] return_config=True now extracts just config, not full tarfile #6346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smajumdar <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| save_path = save_path.replace(".nemo", "_XYZ.nemo") | ||
| super().save_to(model, save_path) | ||
|
|
||
| class MockModelV2(MockModel): |
Check notice
Code scanning / CodeQL
Unused local variable
SeanNaren
reviewed
Apr 1, 2023
| @@ -372,7 +372,7 @@ def restore_from( | |||
| loaded_params = super().load_config_and_state_dict( | |||
| calling_cls, restore_path, override_config_path, map_location, strict, return_config, trainer, | |||
| ) | |||
| if not isinstance(loaded_params, tuple): | |||
| if not isinstance(loaded_params, tuple) or return_config is True: | |||
There was a problem hiding this comment.
Suggested change
| if not isinstance(loaded_params, tuple) or return_config is True: | |
| if not isinstance(loaded_params, tuple) or return_config: |
Could we not just simplify to this? Seems it's always a bool
There was a problem hiding this comment.
I prefer explicit checks generally, even for bool assertion
SeanNaren
approved these changes
Apr 1, 2023
okuchaiev
approved these changes
Apr 2, 2023
1-800-BAD-CODE
pushed a commit
to 1-800-BAD-CODE/NeMo
that referenced
this pull request
Apr 4, 2023
…VIDIA#6346) Signed-off-by: smajumdar <[email protected]> Signed-off-by: shane carroll <[email protected]>
titu1994
added a commit
that referenced
this pull request
Apr 6, 2023
* [Core] return_config=True now extracts just config, not full tarfile (#6346) Signed-off-by: smajumdar <[email protected]> Signed-off-by: shane carroll <[email protected]> * specaug speedup Signed-off-by: shane carroll <[email protected]> * comments Signed-off-by: shane carroll <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: shane carroll <[email protected]> --------- Signed-off-by: smajumdar <[email protected]> Signed-off-by: shane carroll <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
…VIDIA#6346) Signed-off-by: smajumdar <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* [Core] return_config=True now extracts just config, not full tarfile (NVIDIA#6346) Signed-off-by: smajumdar <[email protected]> Signed-off-by: shane carroll <[email protected]> * specaug speedup Signed-off-by: shane carroll <[email protected]> * comments Signed-off-by: shane carroll <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: shane carroll <[email protected]> --------- Signed-off-by: smajumdar <[email protected]> Signed-off-by: shane carroll <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Make return_config=True now only extract out the yaml files from the tarfile, preventing opening and file extractions of all files (should significantly speedup return_config=True for Billion parameter models).
Collection: [Core, ASR, NLP, TTS]
Changelog
Usage
Before your PR is "Ready for review"
Pre checks:
PR Type: