Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RNNT Joint narrow() #6336

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Fix RNNT Joint narrow() #6336

merged 2 commits into from
Mar 31, 2023

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Fixes a but in the signature of narrow().
Fixes #6328

Collection: [ASR]

Changelog

  • Casts the length input of all narrow() to int() explicitly

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@github-actions github-actions bot added the ASR label Mar 31, 2023
@titu1994 titu1994 merged commit 834ee7b into NVIDIA:r1.17.0 Mar 31, 2023
@titu1994 titu1994 deleted the fix_rnnt branch March 31, 2023 04:53
github-actions bot pushed a commit that referenced this pull request Mar 31, 2023
@titu1994 @web-flow
Fix RNNT Joint narrow() (#6336)
dc22c70 
* Fix RNNT Joint narrow()

Signed-off-by: smajumdar <[email protected]>

* Fix RNNT Joint narrow()

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
titu1994 added a commit that referenced this pull request Mar 31, 2023
@github-actions @titu1994
Fix RNNT Joint narrow() (#6336) (#6337)
60776ed 
* Fix RNNT Joint narrow()



* Fix RNNT Joint narrow()



---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
@github-actions @titu1994 @hsiehjackson
Fix RNNT Joint narrow() (NVIDIA#6336) (NVIDIA#6337)
4a3ed4c 
* Fix RNNT Joint narrow()



* Fix RNNT Joint narrow()



---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ASR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@titu1994