-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: minor cleanup #6311
chore: minor cleanup #6311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add max_dim argument to the original get_initial_cache_state in the StreamingEncoder class.
Signed-off-by: Greg Clark <[email protected]>
Signed-off-by: Greg Clark <[email protected]>
02b5a54
to
9936bb6
Compare
There is still a problem with this onnx export Before there was code in causal_convs.py to prevented this issue, but for some reason it was removed. |
Would you please send a reference to the exact lines which are dropped? |
@@ -29,7 +29,7 @@ | |||
pass | |||
|
|||
@abstractmethod | |||
def get_initial_cache_state(self, batch_size, dtype, device): | |||
def get_initial_cache_state(self, batch_size, dtype, device, max_dim): |
Check notice
Code scanning / CodeQL
Mismatch between signature and use of an overridden method
Signed-off-by: Greg Clark <[email protected]>
After my comment code was added to prevent the export issue: However at runtime using this exported onnx model there is a onnx exception |
So the issue is now fixed? |
Yes, I still have to adapt my decoder to work with the changed caching, to see if decoding works too. |
There is still a problem, even the built in verify_runtime fails: (I had to change CUDAExecutionProvider to CPUExecutionProvider) |
* chore: minor cleanup Signed-off-by: Greg Clark <[email protected]> * Adding docs and missing param Signed-off-by: Greg Clark <[email protected]> * Clip cache_keep_size in causal_convs Signed-off-by: Greg Clark <[email protected]> --------- Signed-off-by: Greg Clark <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
What does this PR do ?
Minor cleaning, followup from #5837
@VahidooX I think I've address you comments. Let me know if I missed something.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
@VahidooX
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information