[BugFix] Fix multi-processing bug in data simulator #6310

tango4j · 2023-03-28T03:01:21Z

What does this PR do ?

Fix multi-processing bug in data simulator

Collection:
ASR

Changelog

Add specific line by line info of high level changes in this PR.
Changed silence sampling logic to follow overlap sampling logic
Changed perturbator config structure to include add_xxx_aug in side xxxxxx_augmentor
Some comment changes
Fixed annotation file writing mechanism to fix multi-processing issue.
Added more unit-tests for util functions

Usage

This script creates a synthetic diarization session using the provided audio dataset with ctm files.
Usage:
  python <NEMO_ROOT>/tools/speech_data_simulator/multispeaker_simulator.py  \
    num_workers=10 \
    data_simulator.random_seed=42 \
    data_simulator.manifest_filepath=manifest_with_alignment_file.json \
    data_simulator.outputs.output_dir=./simulated_data \
    data_simulator.outputs.output_filename=sim_spk2_sess20 \
    data_simulator.session_config.num_sessions=1000 \
    data_simulator.session_config.num_speakers=2 \
    data_simulator.session_config.session_length=20 \
    data_simulator.background_noise.add_bg=False \
    data_simulator.background_noise.background_manifest=background_noise.json \
    data_simulator.background_noise.snr=40 \

Check out parameters in ./conf/data_simulator.yaml.

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

Signed-off-by: Taejin Park <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: Taejin Park <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: Taejin Park <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: Taejin Park <[email protected]>

…into fix_data_simulator

for more information, see https://pre-commit.ci

Signed-off-by: Taejin Park <[email protected]>

…into fix_data_simulator

Signed-off-by: Taejin Park <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: Taejin Park <[email protected]>

…into fix_data_simulator

Signed-off-by: Taejin Park <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: stevehuang52 <[email protected]>

stevehuang52

I've tested the code and found the silence/overlap distributions satisfactory enough, thanks for the great work~!

tango4j · 2023-03-30T01:04:42Z

Please do not merge this until we test tutorial notebooks. Thanks.

Signed-off-by: Taejin Park <[email protected]>

tango4j · 2023-03-30T04:09:04Z

nemo/collections/asr/data/data_simulation.py

+        white_noise:
+            prob (float): Probability of adding white noise (Default: 1.0)
+            min_level (float): minimum gain in terms of dB
+            max_level (float): minimum gain in terms of dB


minimum -> maximum

stevehuang52

LGTM

* [BugFix] Fix multi-processing bug in data simulator Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed file writing mechanism to use a text buffer Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed init functions Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Removed unnecessary lines and fixed failed tests Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Removed unnecessary lines Signed-off-by: Taejin Park <[email protected]> * changed yaml file structure for perturbation Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Changing yaml structure for augmentors Signed-off-by: Taejin Park <[email protected]> * Fixed perturb yaml file structure Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update saving metadata Signed-off-by: stevehuang52 <[email protected]> * Fixed version log. Tested notebooks Signed-off-by: Taejin Park <[email protected]> --------- Signed-off-by: Taejin Park <[email protected]> Signed-off-by: stevehuang52 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: stevehuang52 <[email protected]> Co-authored-by: He Huang (Steve) <[email protected]> Signed-off-by: hsiehjackson <[email protected]>

[BugFix] Fix multi-processing bug in data simulator

807b63a

Signed-off-by: Taejin Park <[email protected]>

github-actions bot added the ASR label Mar 28, 2023

pre-commit-ci bot and others added 6 commits March 28, 2023 03:02

[pre-commit.ci] auto fixes from pre-commit.com hooks

9d126cd

for more information, see https://pre-commit.ci

Fixed file writing mechanism to use a text buffer

60f39e7

Signed-off-by: Taejin Park <[email protected]>

Resolved conflicts

ec3b625

Signed-off-by: Taejin Park <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

835315e

for more information, see https://pre-commit.ci

Fixed init functions

717670d

Signed-off-by: Taejin Park <[email protected]>

Fixed init functions

3a97414

Signed-off-by: Taejin Park <[email protected]>

tango4j requested a review from stevehuang52 March 28, 2023 03:40

pre-commit-ci bot and others added 10 commits March 28, 2023 03:40

[pre-commit.ci] auto fixes from pre-commit.com hooks

7e4a149

for more information, see https://pre-commit.ci

Removed unnecessary lines and fixed failed tests

3e36041

Signed-off-by: Taejin Park <[email protected]>

Merge branch 'fix_data_simulator' of https://github.com/tango4j/NeMo …

a3becfd

…into fix_data_simulator

[pre-commit.ci] auto fixes from pre-commit.com hooks

6b5e033

for more information, see https://pre-commit.ci

Removed unnecessary lines

35945e5

Signed-off-by: Taejin Park <[email protected]>

Merge branch 'fix_data_simulator' of https://github.com/tango4j/NeMo …

5c8a32b

…into fix_data_simulator

changed yaml file structure for perturbation

3f8752c

Signed-off-by: Taejin Park <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

d6e6726

for more information, see https://pre-commit.ci

Changing yaml structure for augmentors

380cf57

Signed-off-by: Taejin Park <[email protected]>

Merge branch 'fix_data_simulator' of https://github.com/tango4j/NeMo …

64c42c6

…into fix_data_simulator

tango4j marked this pull request as ready for review March 28, 2023 21:23

tango4j and others added 4 commits March 28, 2023 17:32

Fixed perturb yaml file structure

34e594b

Signed-off-by: Taejin Park <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

45ba8ea

for more information, see https://pre-commit.ci

update saving metadata

811790c

Signed-off-by: stevehuang52 <[email protected]>

Merge branch 'main' into fix_data_simulator

01ffa87

stevehuang52 previously approved these changes Mar 29, 2023

View reviewed changes

Fixed version log. Tested notebooks

803d387

Signed-off-by: Taejin Park <[email protected]>

tango4j dismissed stevehuang52’s stale review via 803d387 March 30, 2023 19:26

tango4j added 2 commits March 30, 2023 12:28

Merge branch 'main' into fix_data_simulator

69acec0

Merge branch 'main' into fix_data_simulator

8277480

tango4j commented Mar 30, 2023

View reviewed changes

stevehuang52 approved these changes Mar 30, 2023

View reviewed changes

tango4j merged commit 5d3fa84 into NVIDIA:main Mar 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Fix multi-processing bug in data simulator #6310

[BugFix] Fix multi-processing bug in data simulator #6310

tango4j commented Mar 28, 2023 •

edited

Loading

stevehuang52 left a comment

tango4j commented Mar 30, 2023

tango4j Mar 30, 2023

tango4j Mar 30, 2023

stevehuang52 left a comment

[BugFix] Fix multi-processing bug in data simulator #6310

[BugFix] Fix multi-processing bug in data simulator #6310

Conversation

tango4j commented Mar 28, 2023 • edited Loading

What does this PR do ?

Changelog

Usage

Before your PR is "Ready for review"

Who can review?

Additional Information

stevehuang52 left a comment

Choose a reason for hiding this comment

tango4j commented Mar 30, 2023

tango4j Mar 30, 2023

Choose a reason for hiding this comment

tango4j Mar 30, 2023

Choose a reason for hiding this comment

stevehuang52 left a comment

Choose a reason for hiding this comment

tango4j commented Mar 28, 2023 •

edited

Loading