Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CTC decoder setup #6303

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Fix for CTC decoder setup #6303

merged 1 commit into from
Mar 27, 2023

Conversation

vsl9
Copy link
Collaborator

@vsl9 vsl9 commented Mar 27, 2023

What does this PR do ?

The PR adds support of recent distutils for CTC decoder installation.

Collection: ASR (optional CTC beam search decoder)

Changelog

  • Fixed CTC decoder installation to support recent distutils

Usage

N/A

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@titu1994 titu1994 merged commit 8df0796 into r1.17.0 Mar 27, 2023
@titu1994 titu1994 deleted the ctc-decoder-setup-fix branch March 27, 2023 21:36
github-actions bot pushed a commit that referenced this pull request Mar 27, 2023
titu1994 pushed a commit that referenced this pull request Mar 27, 2023
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
…6303) (NVIDIA#6305)

Signed-off-by: Vitaly Lavrukhin <[email protected]>
Co-authored-by: Vitaly Lavrukhin <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants