Fix buckeing seeding #6254
Merged
Fix buckeing seeding #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vahid <[email protected]>
Signed-off-by: Vahid <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Mar 19, 2023
* fixed the seeding bug of bucketing. Signed-off-by: Vahid <[email protected]> * fixed the seeding bug of bucketing. Signed-off-by: Vahid <[email protected]> --------- Signed-off-by: Vahid <[email protected]>
titu1994
pushed a commit
that referenced
this pull request
Mar 19, 2023
* fixed the seeding bug of bucketing. * fixed the seeding bug of bucketing. --------- Signed-off-by: Vahid <[email protected]> Co-authored-by: Vahid Noroozi <[email protected]>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* fixed the seeding bug of bucketing. * fixed the seeding bug of bucketing. --------- Signed-off-by: Vahid <[email protected]> Co-authored-by: Vahid Noroozi <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
When the global seeding is set and controlled by the user, the fully_randomized bucketing uses the same order of buckets on all workers. This PR fixes this seeding bug of the bucketing dataset by adding the rank of data loader to the seed.
Changelog
PR Type: