Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASR Beam search documentation #6244

Merged
merged 2 commits into from
Mar 18, 2023
Merged

ASR Beam search documentation #6244

merged 2 commits into from
Mar 18, 2023

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Update docstrings for asr beam search computation

Collection: [ASR]

Changelog

  • Update train kenlm arg
  • Update args for beam search eval

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@github-actions github-actions bot added the ASR label Mar 17, 2023
@titu1994 titu1994 requested a review from VahidooX March 17, 2023 23:56
@titu1994
Fix typo
4dd7b4b 
Signed-off-by: smajumdar <[email protected]>
VahidooX
VahidooX approved these changes Mar 18, 2023
View reviewed changes
Copy link
Collaborator

@VahidooX VahidooX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titu1994 titu1994 merged commit a5bc80a into NVIDIA:r1.17.0 Mar 18, 2023
@titu1994 titu1994 deleted the asr_docs branch March 18, 2023 08:52
github-actions bot pushed a commit that referenced this pull request Mar 18, 2023
@titu1994 @web-flow
ASR Beam search documentation (#6244)
d5757ca 
* Update ASR Beam Search decoding docs

Signed-off-by: smajumdar <[email protected]>

* Fix typo

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
titu1994 added a commit that referenced this pull request Mar 18, 2023
@github-actions @titu1994
ASR Beam search documentation (#6244) (#6247)
a0f584a 
* Update ASR Beam Search decoding docs



* Fix typo



---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
@github-actions @titu1994 @hsiehjackson
ASR Beam search documentation (NVIDIA#6244) (NVIDIA#6247)
fda333d 
* Update ASR Beam Search decoding docs



* Fix typo



---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VahidooX VahidooX VahidooX approved these changes

Assignees
No one assigned
Labels
ASR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@titu1994 @VahidooX