Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small bugfix and add asr evaluator to doc #6229

Merged
merged 3 commits into from
Mar 17, 2023
Merged

small bugfix and add asr evaluator to doc #6229

merged 3 commits into from
Mar 17, 2023

Conversation

fayejf
Copy link
Collaborator

@fayejf fayejf commented Mar 16, 2023

What does this PR do ?

small bugfixes for rng in augmentor and eval_metrics for asr evaluator
add asr evaluator to doc.

[TODO] add asr evaluator to main page once we merge 1.17.0 to main so we had link to doc.

Collection: ASR

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: fayejf <[email protected]>
Copy link
Collaborator

@stevehuang52 stevehuang52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks~

@stevehuang52 stevehuang52 merged commit 6c024ca into r1.17.0 Mar 17, 2023
@stevehuang52 stevehuang52 deleted the bugfix_1.17 branch March 17, 2023 13:32
github-actions bot pushed a commit that referenced this pull request Mar 17, 2023
* small fix eval_metrics

Signed-off-by: fayejf <[email protected]>

* fix rng

Signed-off-by: fayejf <[email protected]>

* add asr evaluator to doc

Signed-off-by: fayejf <[email protected]>

---------

Signed-off-by: fayejf <[email protected]>
XuesongYang pushed a commit that referenced this pull request Mar 21, 2023
* small fix eval_metrics
* fix rng
* add asr evaluator to doc

---------

Signed-off-by: fayejf <[email protected]>
Co-authored-by: fayejf <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* small fix eval_metrics
* fix rng
* add asr evaluator to doc

---------

Signed-off-by: fayejf <[email protected]>
Co-authored-by: fayejf <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants