Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook fixes #6212

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Notebook fixes #6212

merged 2 commits into from
Mar 15, 2023

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Doc fixes and typos for tutorials

Collection: [ASR]

Changelog

  • Fix incorrect line end of ASR adapters
  • Fix typos

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@titu1994 titu1994 changed the base branch from main to r1.17.0 March 15, 2023 22:44
@titu1994 titu1994 merged commit de31379 into NVIDIA:r1.17.0 Mar 15, 2023
@titu1994 titu1994 deleted the notebook_fixes branch March 15, 2023 22:45
github-actions bot pushed a commit that referenced this pull request Mar 15, 2023
@titu1994 @web-flow
Notebook fixes (#6212)
0f53061 
* Remove incorrect comma at end of line for json

Signed-off-by: smajumdar <[email protected]>

* Fix typos

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
XuesongYang pushed a commit that referenced this pull request Mar 16, 2023
@github-actions @titu1994
Notebook fixes (#6212) (#6213)
1937541 
* Remove incorrect comma at end of line for json
* Fix typos
---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
titu1994 added a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
@github-actions @titu1994
Notebook fixes (NVIDIA#6212) (NVIDIA#6213)
c329fa2 
* Remove incorrect comma at end of line for json
* Fix typos
---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
@github-actions @titu1994 @hsiehjackson
Notebook fixes (NVIDIA#6212) (NVIDIA#6213)
437a31e 
* Remove incorrect comma at end of line for json
* Fix typos
---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ASR CI NLP Speaker Tasks TTS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@titu1994