Bug fixing for bucketing dataset #6191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ep calculation. Signed-off-by: Vahid <[email protected]>
…ep calculation. Signed-off-by: Vahid <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2023
* made the bucketing dataloader to loop indefinitely to fix a bug in step calculation. Signed-off-by: Vahid <[email protected]> * made the bucketing dataloader to loop indefinitely to fix a bug in step calculation. Signed-off-by: Vahid <[email protected]> --------- Signed-off-by: Vahid <[email protected]>
titu1994
pushed a commit
that referenced
this pull request
Mar 18, 2023
* made the bucketing dataloader to loop indefinitely to fix a bug in step calculation. * made the bucketing dataloader to loop indefinitely to fix a bug in step calculation. --------- Signed-off-by: Vahid <[email protected]> Co-authored-by: Vahid Noroozi <[email protected]>
8 tasks
|
@titu1994 |
Yes, please use 23.03 instead. |
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* made the bucketing dataloader to loop indefinitely to fix a bug in step calculation. * made the bucketing dataloader to loop indefinitely to fix a bug in step calculation. --------- Signed-off-by: Vahid <[email protected]> Co-authored-by: Vahid Noroozi <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes a bug in the ASR bucketing which made the training to hang at the end of first epoch.
Collection: ASR
Changelog
PR Type: