Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sequence parallel support to Rope positional embedding #6178

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

yidong72
Copy link
Collaborator

Add sequence parallel support to Rope positional embedding

Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Copy link
Contributor

@MaximumEntropy MaximumEntropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@MaximumEntropy MaximumEntropy merged commit 88b7a06 into main Mar 14, 2023
@MaximumEntropy MaximumEntropy deleted the rope_seq_parallel branch March 14, 2023 00:58
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* support sp

Signed-off-by: Yi Dong <[email protected]>

* use parallel_state

Signed-off-by: Yi Dong <[email protected]>

---------

Signed-off-by: Yi Dong <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* support sp

Signed-off-by: Yi Dong <[email protected]>

* use parallel_state

Signed-off-by: Yi Dong <[email protected]>

---------

Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants