Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert Megatron LM ckpt to NeMo PP support. #6159

Merged
merged 15 commits into from
Mar 9, 2023
Merged

convert Megatron LM ckpt to NeMo PP support. #6159

merged 15 commits into from
Mar 9, 2023

Conversation

yidong72
Copy link
Collaborator

@yidong72 yidong72 commented Mar 9, 2023

  1. Fixed the bug in the script to convert Megatron LM ckpt to NeMo.
  2. Fixed a bug in the GPT PP that we should only add output layer for the last PP rank.
  3. Overwrite the precision in the eval script and fix the web server.

Copy link
Contributor

@MaximumEntropy MaximumEntropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yidong72 yidong72 merged commit 2327fec into main Mar 9, 2023
@yidong72 yidong72 deleted the convert_ckpt branch March 9, 2023 20:23
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* fix convert script

Signed-off-by: Yi Dong <[email protected]>

* fix filename eror

Signed-off-by: Yi Dong <[email protected]>

* use none batch size

Signed-off-by: Yi Dong <[email protected]>

* revert

Signed-off-by: Yi Dong <[email protected]>

* working

Signed-off-by: Yi Dong <[email protected]>

* fix the conversion bug

Signed-off-by: Yi Dong <[email protected]>

* use older version

Signed-off-by: Yi Dong <[email protected]>

* fix rope

Signed-off-by: Yi Dong <[email protected]>

* overwrite the precision

Signed-off-by: Yi Dong <[email protected]>

* fix port num

Signed-off-by: Yi Dong <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix the event loop

Signed-off-by: Yi Dong <[email protected]>

---------

Signed-off-by: Yi Dong <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* fix convert script

Signed-off-by: Yi Dong <[email protected]>

* fix filename eror

Signed-off-by: Yi Dong <[email protected]>

* use none batch size

Signed-off-by: Yi Dong <[email protected]>

* revert

Signed-off-by: Yi Dong <[email protected]>

* working

Signed-off-by: Yi Dong <[email protected]>

* fix the conversion bug

Signed-off-by: Yi Dong <[email protected]>

* use older version

Signed-off-by: Yi Dong <[email protected]>

* fix rope

Signed-off-by: Yi Dong <[email protected]>

* overwrite the precision

Signed-off-by: Yi Dong <[email protected]>

* fix port num

Signed-off-by: Yi Dong <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix the event loop

Signed-off-by: Yi Dong <[email protected]>

---------

Signed-off-by: Yi Dong <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants