-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert Megatron LM ckpt to NeMo PP support. #6159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yidong72
commented
Mar 9, 2023
- Fixed the bug in the script to convert Megatron LM ckpt to NeMo.
- Fixed a bug in the GPT PP that we should only add output layer for the last PP rank.
- Overwrite the precision in the eval script and fix the web server.
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Yi Dong <[email protected]>
MaximumEntropy
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
* fix convert script Signed-off-by: Yi Dong <[email protected]> * fix filename eror Signed-off-by: Yi Dong <[email protected]> * use none batch size Signed-off-by: Yi Dong <[email protected]> * revert Signed-off-by: Yi Dong <[email protected]> * working Signed-off-by: Yi Dong <[email protected]> * fix the conversion bug Signed-off-by: Yi Dong <[email protected]> * use older version Signed-off-by: Yi Dong <[email protected]> * fix rope Signed-off-by: Yi Dong <[email protected]> * overwrite the precision Signed-off-by: Yi Dong <[email protected]> * fix port num Signed-off-by: Yi Dong <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix the event loop Signed-off-by: Yi Dong <[email protected]> --------- Signed-off-by: Yi Dong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* fix convert script Signed-off-by: Yi Dong <[email protected]> * fix filename eror Signed-off-by: Yi Dong <[email protected]> * use none batch size Signed-off-by: Yi Dong <[email protected]> * revert Signed-off-by: Yi Dong <[email protected]> * working Signed-off-by: Yi Dong <[email protected]> * fix the conversion bug Signed-off-by: Yi Dong <[email protected]> * use older version Signed-off-by: Yi Dong <[email protected]> * fix rope Signed-off-by: Yi Dong <[email protected]> * overwrite the precision Signed-off-by: Yi Dong <[email protected]> * fix port num Signed-off-by: Yi Dong <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix the event loop Signed-off-by: Yi Dong <[email protected]> --------- Signed-off-by: Yi Dong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.