Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] Add univnet scheduler #6157

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Conversation

ArtyomZemlyak
Copy link
Contributor

What does this PR do ?

Add scheduler for univnet model.

Collection: [TTS]

Changelog

  • Add get_warmup_steps into UnivNetModel
  • Change configure_optimizers in UnivNetModel for scheduler support

Usage

Standart usage of scheduler

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Артём Земляк and others added 2 commits March 9, 2023 09:33
@github-actions github-actions bot added the TTS label Mar 9, 2023
@ArtyomZemlyak
Copy link
Contributor Author

@okuchaiev
Hi!
Can you review?

Copy link
Collaborator

@XuesongYang XuesongYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Out of my curiosity, after applying these schedulers to univnet, did you observe better performance over the one without explicitly applying schedulers?

@XuesongYang XuesongYang merged commit 899cf81 into NVIDIA:main Mar 14, 2023
@ArtyomZemlyak
Copy link
Contributor Author

@XuesongYang
Some improvements exists. But need more training tests.

sched - CosineAnnealing with warmup ratio 0.02
Yellow - its finetuning from another language and voice.
image
image
image
image

@XuesongYang
Copy link
Collaborator

XuesongYang commented Mar 14, 2023

@XuesongYang Some improvements exists. But need more training tests.

Thank you for sharing! From your plots, it seems promising by tweaking the scheduler's parameters.

As a side note: we have shifted the vocoder model to hifigan from univnet. So probably we will not invest to improve univnet. But again, you are welcome to share any practical and better configuration setups of univnet if you achieve better performance. We can then pick it up, train/fine-tune it again, and update our univnet NGC model checkpoints. Please reach out in the issues ;)

titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
Signed-off-by: Артём Земляк <[email protected]>
Co-authored-by: Артём Земляк <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Signed-off-by: Артём Земляк <[email protected]>
Co-authored-by: Артём Земляк <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants