-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTS] Add univnet scheduler #6157
Conversation
Signed-off-by: Артём Земляк <[email protected]>
@okuchaiev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks. Out of my curiosity, after applying these schedulers to univnet, did you observe better performance over the one without explicitly applying schedulers?
@XuesongYang sched - CosineAnnealing with warmup ratio 0.02 |
Thank you for sharing! From your plots, it seems promising by tweaking the scheduler's parameters. As a side note: we have shifted the vocoder model to hifigan from univnet. So probably we will not invest to improve univnet. But again, you are welcome to share any practical and better configuration setups of univnet if you achieve better performance. We can then pick it up, train/fine-tune it again, and update our univnet NGC model checkpoints. Please reach out in the issues ;) |
Signed-off-by: Артём Земляк <[email protected]> Co-authored-by: Артём Земляк <[email protected]>
Signed-off-by: Артём Земляк <[email protected]> Co-authored-by: Артём Земляк <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
What does this PR do ?
Add scheduler for univnet model.
Collection: [TTS]
Changelog
get_warmup_steps
intoUnivNetModel
configure_optimizers
inUnivNetModel
for scheduler supportUsage
Standart usage of scheduler
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information