Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes in docs and RNNT #6156

Merged
merged 3 commits into from
Mar 12, 2023
Merged

Various fixes in docs and RNNT #6156

merged 3 commits into from
Mar 12, 2023

Conversation

titu1994
Copy link
Collaborator

@titu1994 titu1994 commented Mar 9, 2023

What does this PR do ?

Fixes for tests and docs

Collection: [Docs, ASR]

Changelog

  • Fix dark mode in NeMo docs
  • Fix issue with flaky RNNT test where the seq length can be off by one due to minute perturbation during beam search

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@titu1994 titu1994 requested a review from ericharper March 9, 2023 23:26
@github-actions github-actions bot added the ASR label Mar 11, 2023
@titu1994 titu1994 merged commit beb5fbd into NVIDIA:main Mar 12, 2023
@titu1994 titu1994 deleted the various_fixes branch March 12, 2023 20:49
titu1994 added a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
@titu1994
Various fixes in docs and RNNT (NVIDIA#6156)
17e0e5d 
* Fix dark mode in NeMo Docs

Signed-off-by: smajumdar <[email protected]>

* Fix RNNT test

Signed-off-by: smajumdar <[email protected]>

* Add italian and esperanto models

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
@titu1994 @hsiehjackson
Various fixes in docs and RNNT (NVIDIA#6156)
439a3f6 
* Fix dark mode in NeMo Docs

Signed-off-by: smajumdar <[email protected]>

* Fix RNNT test

Signed-off-by: smajumdar <[email protected]>

* Add italian and esperanto models

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper Awaiting requested review from ericharper

Assignees
No one assigned
Labels
ASR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@titu1994