[TTS] Move Spanish polyphones from heteronym to dictionary #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redoctopus
previously approved these changes
Mar 1, 2023
Signed-off-by: Ryan <[email protected]>
Signed-off-by: Ryan <[email protected]>
XuesongYang
approved these changes
Mar 6, 2023
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
* [TTS] Move Spanish polyphones from heteronym to dictionary * [TTS] Fix spacing in Spanish dictionary --------- Signed-off-by: Ryan <[email protected]>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* [TTS] Move Spanish polyphones from heteronym to dictionary * [TTS] Fix spacing in Spanish dictionary --------- Signed-off-by: Ryan <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Spanish does not have heteronyms, only polyphones (eg. region-specific pronunciations of the same word). To make this clearer, I am removing the heteronyms file and placing the alternative pronunciations into the dictionary.
Collection: [TTS]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type: