Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS bugfix #6122

Merged
merged 1 commit into from
Mar 1, 2023
Merged

CS bugfix #6122

merged 1 commit into from
Mar 1, 2023

Conversation

bmwshop
Copy link
Collaborator

@bmwshop bmwshop commented Mar 1, 2023

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.
Fixes bug in processing multilingual / codeswitched tarred datasets

Collection: [Note which collection this PR will affect]
ASR

Changelog

  • Add specific line by line info of high level changes in this PR
  • isinstance(args[0], Iterable) replaced by List
  • Because a string is an Iterable!

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • [ X] Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Dima Rekesh <[email protected]>
@bmwshop bmwshop added bug Something isn't working ASR labels Mar 1, 2023
@bmwshop bmwshop merged commit bbff298 into main Mar 1, 2023
@bmwshop bmwshop deleted the cs_bug branch March 1, 2023 07:32
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
Signed-off-by: Dima Rekesh <[email protected]>
Co-authored-by: Dima Rekesh <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Signed-off-by: Dima Rekesh <[email protected]>
Co-authored-by: Dima Rekesh <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants