Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS][refactor] Part 3 - nemo.collections.tts.g2p.models #6113

Merged
merged 4 commits into from
Feb 25, 2023

Conversation

XuesongYang
Copy link
Collaborator

What does this PR do ?

Task 3: break down nemo.collections.tts.g2p.models and save to nemo.collection.tts.models

  • base.py # move and merge tts/g2p/models/g2p_model.py::G2PModel class here because it is the base model for g2p.
  • g2p_ctc.py # move and rename tts/g2p/models/ctc_g2p.py here. File name uses the same format as fastpitch_*.py
  • g2p_t5.py # move and rename tts/g2p/models/t5_g2p.py here.
  • g2p_heteronym_classification.py # move and rename tts/g2p/models/heteronym_classifiation.py here.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the TTS label Feb 24, 2023
Signed-off-by: Xuesong Yang <[email protected]>
@github-actions github-actions bot added the CI label Feb 24, 2023
@XuesongYang XuesongYang marked this pull request as ready for review February 25, 2023 00:31
Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Brief ramble: I'm trying but can't think of a better solution than renaming heteronym_classification -> g2p_heteronym_classification because it might be slightly misleading (only does the classification and not full G2P). But it falls enough under that umbrella that I can't complain too much, and makes for better organization of files in TTS anyway.

@XuesongYang
Copy link
Collaborator Author

XuesongYang commented Feb 25, 2023

renaming heteronym_classification -> g2p_heteronym_classification

yeah, same feeling as yours though. The reason why I added the prefix g2p is because HeteronymClassificationModel is used to find the best pronunciation from candidate dict entries. So literally, it is part of converting graphemes into phonemes.

heteronym_classification itself sounds more like a different task, like purely text classification irrelevant to any pronunciations.

@XuesongYang XuesongYang merged commit 7185d97 into main Feb 25, 2023
@XuesongYang XuesongYang deleted the refactor-tts-g2p-models branch February 25, 2023 09:22
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* [TTS][refactor] Part 3 - nemo.collections.tts.g2p.models
* fixed invalid paths.
* update copyright header
---------
Signed-off-by: Xuesong Yang <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* [TTS][refactor] Part 3 - nemo.collections.tts.g2p.models
* fixed invalid paths.
* update copyright header
---------
Signed-off-by: Xuesong Yang <[email protected]>

Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants