-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTS][refactor] Part 3 - nemo.collections.tts.g2p.models #6113
Conversation
Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: Xuesong Yang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Brief ramble: I'm trying but can't think of a better solution than renaming heteronym_classification
-> g2p_heteronym_classification
because it might be slightly misleading (only does the classification and not full G2P). But it falls enough under that umbrella that I can't complain too much, and makes for better organization of files in TTS anyway.
yeah, same feeling as yours though. The reason why I added the prefix
|
* [TTS][refactor] Part 3 - nemo.collections.tts.g2p.models * fixed invalid paths. * update copyright header --------- Signed-off-by: Xuesong Yang <[email protected]>
* [TTS][refactor] Part 3 - nemo.collections.tts.g2p.models * fixed invalid paths. * update copyright header --------- Signed-off-by: Xuesong Yang <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
What does this PR do ?
Task 3: break down nemo.collections.tts.g2p.models and save to nemo.collection.tts.models
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information