Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS][refactor] Part 2 - nemo.colletions.tts.parts #6105

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Conversation

XuesongYang
Copy link
Collaborator

@XuesongYang XuesongYang commented Feb 24, 2023

What does this PR do ?

Task 2: re-organize nemo.collection.tts.parts

  • utils

    • tts_dataset_utils.py # move torch/helpers.py here; merge tts/data/data_utils.py here.
    • g2p_utils.py # move g2p/data/data_utils.py here * Evelina may comment.
    • helpers.py # move tts/helpers/helpers.py here. Note that copyright header mixed with BSD 3-Clause. So not sure how to merge to ones with only Nvidia copyright.
    • splines.py # move tts/helpers/splines.py here. Same as above, it mixed Nvidia and MIT copyrights.
  • preprocessing

    • audio_trimmer.py # move data/audio_trimmer.py here

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: Xuesong Yang <[email protected]>
@XuesongYang XuesongYang merged commit 3e8aa5e into main Feb 24, 2023
@XuesongYang XuesongYang deleted the refator-tts-parts branch February 24, 2023 21:20
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* [TTS][refactor] Part 2 - nemo.colletions.tts.parts
* aggregate imports
* added __init__.py
---------
Signed-off-by: Xuesong Yang <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* [TTS][refactor] Part 2 - nemo.colletions.tts.parts
* aggregate imports
* added __init__.py
---------
Signed-off-by: Xuesong Yang <[email protected]>

Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants