Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS][refactor] Part 1 - nemo.collections.tts.data #6099

Merged
merged 7 commits into from
Feb 24, 2023
Merged

Conversation

XuesongYang
Copy link
Collaborator

@XuesongYang XuesongYang commented Feb 24, 2023

What does this PR do ?

This is a series of refactoring tasks forth.
Task 1: re-organize nemo.collections.tts.data

tts_dataset.py  # move torch/data.py here
g2p_dataset.py  # combine g2p/data/ctc_g2p.py, g2p/data/t5_g2p.py, and g2p/data/heteronym_classification_data.py

# 2. update import paths.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: Xuesong Yang <[email protected]>
@XuesongYang XuesongYang changed the title [TTS] refactor nemo.collections.tts.data [TTS][refactor] Part 1 - nemo.collections.tts.data Feb 24, 2023
Signed-off-by: Xuesong Yang <[email protected]>
@XuesongYang XuesongYang marked this pull request as ready for review February 24, 2023 07:02
Copy link
Collaborator

@ekmb ekmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check that you have __init__ files in the folders

@XuesongYang
Copy link
Collaborator Author

Please check that you have __init__ files in the folders

This PR did not create new package, neither remove existing init.py. So we are good.

@XuesongYang XuesongYang merged commit db96414 into main Feb 24, 2023
@XuesongYang XuesongYang deleted the refactor-tts-data branch February 24, 2023 17:43
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* [TTS] refactor nemo.collections.tts.data
* update tutorials
* update line number
* update the year of the copyright header

Signed-off-by: Xuesong Yang <[email protected]>
---------
Signed-off-by: Xuesong Yang <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* [TTS] refactor nemo.collections.tts.data
* update tutorials
* update line number
* update the year of the copyright header

Signed-off-by: Xuesong Yang <[email protected]>
---------
Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants