Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS][refactor] Part 7 - move module from model file. #6098

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Conversation

XuesongYang
Copy link
Collaborator

@XuesongYang XuesongYang commented Feb 24, 2023

What does this PR do ?

Task 7:

  1. remove duplicate import of torch.
  2. GreedyCTCDecoder is actually a module and should move to nemo/collection/tts/modules.
  3. Lack of exposure from import (see below graph). For example, fastpitch_ssl and ssl_tts should be added into __init__.py.
    packages_tts_models

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes.

nemo/collections/tts/modules/ssl_tts.py Outdated Show resolved Hide resolved
@XuesongYang XuesongYang changed the title [TTS] move module from model file. [TTS][refactor] Part 5 - move module from model file. Feb 24, 2023
@XuesongYang XuesongYang changed the title [TTS][refactor] Part 5 - move module from model file. [TTS][refactor] Part 7 - move module from model file. Feb 24, 2023
@redoctopus redoctopus merged commit 0e8720c into main Feb 24, 2023
@redoctopus redoctopus deleted the refactor-tts branch February 24, 2023 06:08
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* [TTS] move module from model file.

Signed-off-by: Xuesong Yang <[email protected]>

* update copyright header

Signed-off-by: Xuesong Yang <[email protected]>

* update copyright header

Signed-off-by: Xuesong Yang <[email protected]>

---------

Signed-off-by: Xuesong Yang <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* [TTS] move module from model file.

Signed-off-by: Xuesong Yang <[email protected]>

* update copyright header

Signed-off-by: Xuesong Yang <[email protected]>

* update copyright header

Signed-off-by: Xuesong Yang <[email protected]>

---------

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants