Megatron Encoder-Decoder Sampler Function #6095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micha Livne <[email protected]>
…oderModel.decode. 2. Added greedy and top k / top p token sample methods. Signed-off-by: Micha Livne <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
MaximumEntropy
previously approved these changes
Feb 28, 2023
2. Improved deocde docstring. Signed-off-by: Micha Livne <[email protected]>
MaximumEntropy
previously approved these changes
Feb 28, 2023
arendu
reviewed
Mar 6, 2023
| log_probs, token_ids = torch.max(torch.nn.functional.log_softmax(output_tensor, dim=-1), dim=-1) | ||
| log_probs, token_ids = sample_token_fn(logits=output_tensor[:, -1, :]) | ||
| # enforce valid range of token ids | ||
| token_ids = torch.clamp(token_ids, max=tokenizer.vocab_size - 1) |
There was a problem hiding this comment.
Not related to this PR, but this seems like a weird use of clamp. Should a token_ids > vocab raise an error? @ericharper
There was a problem hiding this comment.
It can happen due to vocabulary padding (mostly in the early stages of training).
Signed-off-by: Micha Livne <[email protected]>
Signed-off-by: Micha Livne <[email protected]>
for more information, see https://pre-commit.ci
8 tasks
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
* 1. Work0in-progress. Signed-off-by: Micha Livne <[email protected]> * 1. Added support custom token sample function to MegatronLMEncoderDecoderModel.decode. 2. Added greedy and top k / top p token sample methods. Signed-off-by: Micha Livne <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 1. Debugging. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 1. Debugging. * 1. Debugging. * 1. Removed commented code. 2. Improved deocde docstring. Signed-off-by: Micha Livne <[email protected]> * 1. Fixed variable name. Signed-off-by: Micha Livne <[email protected]> * 1. Fixed device assignemnt. Signed-off-by: Micha Livne <[email protected]> * 1. Fixed a bug in PP decoding log probs shape. Signed-off-by: Micha Livne <[email protected]> * 1. Fixed device assignment. Signed-off-by: Micha Livne <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Micha Livne <[email protected]> Co-authored-by: Micha Livne <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sandeep Subramanian <[email protected]>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* 1. Work0in-progress. Signed-off-by: Micha Livne <[email protected]> * 1. Added support custom token sample function to MegatronLMEncoderDecoderModel.decode. 2. Added greedy and top k / top p token sample methods. Signed-off-by: Micha Livne <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 1. Debugging. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 1. Debugging. * 1. Debugging. * 1. Removed commented code. 2. Improved deocde docstring. Signed-off-by: Micha Livne <[email protected]> * 1. Fixed variable name. Signed-off-by: Micha Livne <[email protected]> * 1. Fixed device assignemnt. Signed-off-by: Micha Livne <[email protected]> * 1. Fixed a bug in PP decoding log probs shape. Signed-off-by: Micha Livne <[email protected]> * 1. Fixed device assignment. Signed-off-by: Micha Livne <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Micha Livne <[email protected]> Co-authored-by: Micha Livne <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sandeep Subramanian <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR adds support in external sampler function to Megatron encoder-decoder.
Collection: [Note which collection this PR will affect]
Changelog
MegatronLMEncoderDecoderModel.decode.Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information