Fix k2 and torchaudio installation (Docker, macOS) #6094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Bataev <[email protected]>
Signed-off-by: Vladimir Bataev <[email protected]>
Signed-off-by: Vladimir Bataev <[email protected]>
artbataev
changed the title
Signed-off-by: Vladimir Bataev <[email protected]>
Signed-off-by: Vladimir Bataev <[email protected]>
artbataev
changed the title
artbataev
changed the title
Signed-off-by: Vladimir Bataev <[email protected]>
Signed-off-by: Vladimir Bataev <[email protected]>
Signed-off-by: Vladimir Bataev <[email protected]>
Signed-off-by: Vladimir Bataev <[email protected]>
artbataev
added a commit
to artbataev/NeMo
that referenced
this pull request
Mar 1, 2023
…IA#6094) --------- Signed-off-by: Vladimir Bataev <[email protected]>
8 tasks
titu1994
pushed a commit
that referenced
this pull request
Mar 1, 2023
… (#6124) --------- Signed-off-by: Vladimir Bataev <[email protected]>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
* torchaudio and k2: add flags, make optional Signed-off-by: Vladimir Bataev <[email protected]> * Fix syntax Signed-off-by: Vladimir Bataev <[email protected]> * Fix return code Signed-off-by: Vladimir Bataev <[email protected]> * Fix k2 installation Signed-off-by: Vladimir Bataev <[email protected]> * Fix torchaudio + k2 installation in docker Signed-off-by: Vladimir Bataev <[email protected]> * Fix flags Signed-off-by: Vladimir Bataev <[email protected]> * Fix torchaudio installation Signed-off-by: Vladimir Bataev <[email protected]> * Fix branch ckeck Signed-off-by: Vladimir Bataev <[email protected]> * Fix latest torchaudio installation Signed-off-by: Vladimir Bataev <[email protected]> --------- Signed-off-by: Vladimir Bataev <[email protected]>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* torchaudio and k2: add flags, make optional Signed-off-by: Vladimir Bataev <[email protected]> * Fix syntax Signed-off-by: Vladimir Bataev <[email protected]> * Fix return code Signed-off-by: Vladimir Bataev <[email protected]> * Fix k2 installation Signed-off-by: Vladimir Bataev <[email protected]> * Fix torchaudio + k2 installation in docker Signed-off-by: Vladimir Bataev <[email protected]> * Fix flags Signed-off-by: Vladimir Bataev <[email protected]> * Fix torchaudio installation Signed-off-by: Vladimir Bataev <[email protected]> * Fix branch ckeck Signed-off-by: Vladimir Bataev <[email protected]> * Fix latest torchaudio installation Signed-off-by: Vladimir Bataev <[email protected]> --------- Signed-off-by: Vladimir Bataev <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
REQUIRE_TORCHAUDIOandREQUIRE_K2fortorchaudioandk2in Dockerfilefalse(by default): library will be installed if possible, errors ignoredtrue: if library not installed correctly, end build with errork2installation script on macOSk2installation in Docker (k2depends ontorchaudio)torchaudioinstallation for latest PyTorch versionsapt update && apt install -y libavdevice-devshould be also used before executing install script)NB: This PR doesn't fix
k2+Cuda 12.0compilation errors.Collection: [CI]
Changelog
k2installation script is compatible with macOSk2installation script fails if error occurred during installationDockerfile: add build arguments (see description above)torchaudioinstallation script - fixes for latest PyTorch versions (ffmpeg, match release branch, correct version)Usage
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information