Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding changes to fix the mv error #6087

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

tango4j
Copy link
Collaborator

@tango4j tango4j commented Feb 23, 2023

What does this PR do ?

This PR fixes a line containing bash command "mv".
The line is unnecessary and creating an error.
Also added "rm" command that removes tar file, in case where users run the cell again.

Collection: [Note which collection this PR will affect]
ASR

Changelog

Removed "mv" line.

Usage

This is a ipython notebook.
You can run it at tutorials/speaker_tasks/Speaker_Diarization_Training.ipynb.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Taejin Park <[email protected]>
@tango4j tango4j marked this pull request as ready for review February 23, 2023 00:59
Copy link
Collaborator

@stevehuang52 stevehuang52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@tango4j
Copy link
Collaborator Author

tango4j commented Feb 23, 2023

This PR fixes the following bug:
https://nvbugswb.nvidia.com/NvBugs5/SWBug.aspx?bugid=3975316&cmtNo=

@tango4j tango4j merged commit 66aeb4c into NVIDIA:main Feb 23, 2023
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* Adding changes to fix the mv error

Signed-off-by: Taejin Park <[email protected]>

* Removed unnecessary lines

Signed-off-by: Taejin Park <[email protected]>

---------

Signed-off-by: Taejin Park <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* Adding changes to fix the mv error

Signed-off-by: Taejin Park <[email protected]>

* Removed unnecessary lines

Signed-off-by: Taejin Park <[email protected]>

---------

Signed-off-by: Taejin Park <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants