[TTS] Spectrogram Enhancer: correct dim for length when loading data #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: Roman Korostik <[email protected]>
racoiaws
approved these changes
Feb 23, 2023
|
The fix is approved and merged into the r1.16 brach, this is an autogenerated PR for the main branch |
racoiaws
deleted the
cherry-pick-main-5d039822e3f6d2f43bf03a287bf1a9dd6d9cb691
branch
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
…6074) Signed-off-by: Roman Korostik <[email protected]> Co-authored-by: Roman Korostik <[email protected]>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
…6074) Signed-off-by: Roman Korostik <[email protected]> Co-authored-by: Roman Korostik <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Makes DataLoader for Spectrogram enhancer (#5565) use correct dimension to determine length of the spectrogram.
Currently it uses number of mel bands as length, so in practice enhancer trains on 80x80 patches, which is obviously suboptimal and a bug.
Collection: TTS
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information