Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for flashlight decoder #6071

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

trias702
Copy link
Collaborator

What does this PR do ?

Fixes two small bugs in the flashlight decoder, one due to superfluous import

Collection: ASR

Changelog

  • Two changes to nemo/collections/asr/modules/flashlight_decoder.py

Usage

  • No changes, just continue to use flashlight decoding as normal

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the ASR label Feb 21, 2023
@titu1994
Copy link
Collaborator

Thanks for the fix !

titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
Signed-off-by: Daniel Egert <[email protected]>
Co-authored-by: Daniel Egert <[email protected]>
@trias702 trias702 deleted the flashlight_fixes branch March 27, 2023 21:28
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Signed-off-by: Daniel Egert <[email protected]>
Co-authored-by: Daniel Egert <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants