Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert esperanto into a notebook #6070

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Convert esperanto into a notebook #6070

merged 3 commits into from
Feb 22, 2023

Conversation

SeanNaren
Copy link
Collaborator

@SeanNaren SeanNaren commented Feb 21, 2023 •
edited
Loading

What does this PR do ?

Moves esperanto into a notebook instead of a documentation page.

Collection: ASR

Changelog

  • Move esperanto example to a notebook.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@SeanNaren SeanNaren added the cleanup Code cleanup label Feb 21, 2023
@SeanNaren SeanNaren self-assigned this Feb 21, 2023
@github-actions github-actions bot added the ASR label Feb 21, 2023
titu1994
titu1994 previously approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you !

docs/source/asr/intro.rst
@@ -54,6 +54,5 @@ The full documentation tree is as follows:
api
resources
examples/kinyarwanda_asr.rst
examples/esperanto_asr/esperanto_asr.rst
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move out kiraynwana as well (can be another PR)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep let's do a separate PR

tutorials/asr/README.md Show resolved Hide resolved
@SeanNaren SeanNaren merged commit d06d353 into main Feb 22, 2023
@SeanNaren SeanNaren deleted the move_esperanto branch February 22, 2023 13:21
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
@SeanNaren @titu1994
Convert esperanto into a notebook (NVIDIA#6070)
45dd4eb
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
@SeanNaren @hsiehjackson
Convert esperanto into a notebook (NVIDIA#6070)
1f61f04 
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titu1994 titu1994 titu1994 left review comments

@andrusenkoau andrusenkoau Awaiting requested review from andrusenkoau

Assignees

@SeanNaren SeanNaren

Labels
ASR cleanup Code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SeanNaren @titu1994