P-tuning refactor Part 2/N #6056

arendu · 2023-02-18T08:47:21Z

What does this PR do ?

Follow up of #6054

Refactor of GPT Prompt Tuning to use the same code structure as P-Tuning.

Collection: [NLP]

Changelog

Adds an option to train a PromptEncoder with just the embeddings which is functionally same as prompt-tuning.
Removes references to prompt_tables in gpt prompt learning model.
streamlines the training and inference time code

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

… attribute Signed-off-by: arendu <[email protected]>

Signed-off-by: arendu <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: arendu <[email protected]>

…DIA/NeMo into adithyare/early_stop_ptuning

Signed-off-by: arendu <[email protected]>

…DIA/NeMo into adithyare/early_stop_ptuning

Signed-off-by: arendu <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: arendu <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: arendu <[email protected]>

…IDIA/NeMo into adithyare/refac_ptuning_part2

Signed-off-by: arendu <[email protected]>

arendu · 2023-02-20T06:56:11Z

Verified val loss curves on main vs this PR
https://wandb.ai/nvidia/p_tuning_refactor?workspace=user-adithyare

Signed-off-by: arendu <[email protected]>

for more information, see https://pre-commit.ci

…ning_part2

Signed-off-by: arendu <[email protected]>

for more information, see https://pre-commit.ci

Zhilin123

LGTM, remaining some stylistic issues to be addressed in follow up PR

* patch to allow using tokenizers without additional_special_tokens_ids attribute Signed-off-by: arendu <[email protected]> * early stop callback for prompt/p tuning Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update Signed-off-by: arendu <[email protected]> * added exp manager config for early stop Signed-off-by: arendu <[email protected]> * pushed logic for creating early stopping inside exp manager Signed-off-by: arendu <[email protected]> * pushed logic for creating early stopping inside exp manager Signed-off-by: arendu <[email protected]> * minor updates and added dataclass check Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * more args Signed-off-by: arendu <[email protected]> * more args Signed-off-by: arendu <[email protected]> * wrap tpmlp inside prompt encoder Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updates removed unused imports Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removes typecheck for tpmlp module Signed-off-by: arendu <[email protected]> * refac Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removing refs to PROMPT_TABLE Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove ref to PROMPT_TABLE Signed-off-by: arendu <[email protected]> * minor fix Signed-off-by: arendu <[email protected]> * merged conficts Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * bug fix with tpmlp Signed-off-by: arendu <[email protected]> * inference seems to be working Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * phasing out prompt learning in t5 Signed-off-by: arendu <[email protected]> * revert prompt table to allow t5 to work Signed-off-by: arendu <[email protected]> * updates Signed-off-by: arendu <[email protected]> * updates Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make prompt encoder None in init Signed-off-by: arendu <[email protected]> * update test Signed-off-by: arendu <[email protected]> * fixed init Signed-off-by: arendu <[email protected]> * setting lstm params the old way Signed-off-by: arendu <[email protected]> * revert t5 dataset Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert t5 dataset Signed-off-by: arendu <[email protected]> * revert t5 dataset Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert t5 dataset Signed-off-by: arendu <[email protected]> * save to now works with pp>1 Signed-off-by: arendu <[email protected]> * revert t5 datasets Signed-off-by: arendu <[email protected]> * unused args Signed-off-by: arendu <[email protected]> * make prompt encoder state_dict backwards compatible Signed-off-by: arendu <[email protected]> * pipe taskname to prompt encoder Signed-off-by: arendu <[email protected]> * update Signed-off-by: arendu <[email protected]> * update Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * comment Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: arendu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* patch to allow using tokenizers without additional_special_tokens_ids attribute Signed-off-by: arendu <[email protected]> * early stop callback for prompt/p tuning Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update Signed-off-by: arendu <[email protected]> * added exp manager config for early stop Signed-off-by: arendu <[email protected]> * pushed logic for creating early stopping inside exp manager Signed-off-by: arendu <[email protected]> * pushed logic for creating early stopping inside exp manager Signed-off-by: arendu <[email protected]> * minor updates and added dataclass check Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * more args Signed-off-by: arendu <[email protected]> * more args Signed-off-by: arendu <[email protected]> * wrap tpmlp inside prompt encoder Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updates removed unused imports Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removes typecheck for tpmlp module Signed-off-by: arendu <[email protected]> * refac Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * removing refs to PROMPT_TABLE Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove ref to PROMPT_TABLE Signed-off-by: arendu <[email protected]> * minor fix Signed-off-by: arendu <[email protected]> * merged conficts Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * bug fix with tpmlp Signed-off-by: arendu <[email protected]> * inference seems to be working Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * phasing out prompt learning in t5 Signed-off-by: arendu <[email protected]> * revert prompt table to allow t5 to work Signed-off-by: arendu <[email protected]> * updates Signed-off-by: arendu <[email protected]> * updates Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * make prompt encoder None in init Signed-off-by: arendu <[email protected]> * update test Signed-off-by: arendu <[email protected]> * fixed init Signed-off-by: arendu <[email protected]> * setting lstm params the old way Signed-off-by: arendu <[email protected]> * revert t5 dataset Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert t5 dataset Signed-off-by: arendu <[email protected]> * revert t5 dataset Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert t5 dataset Signed-off-by: arendu <[email protected]> * save to now works with pp>1 Signed-off-by: arendu <[email protected]> * revert t5 datasets Signed-off-by: arendu <[email protected]> * unused args Signed-off-by: arendu <[email protected]> * make prompt encoder state_dict backwards compatible Signed-off-by: arendu <[email protected]> * pipe taskname to prompt encoder Signed-off-by: arendu <[email protected]> * update Signed-off-by: arendu <[email protected]> * update Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * comment Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: arendu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: hsiehjackson <[email protected]>

arendu and others added 30 commits December 15, 2022 10:51

patch to allow using tokenizers without additional_special_tokens_ids…

2b95406

… attribute Signed-off-by: arendu <[email protected]>

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

c131a90

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

9e15c3a

merge main

d0e3669

Signed-off-by: arendu <[email protected]>

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

0a19a5a

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

ec3d57b

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

64e36ba

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

5bfde7e

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

b04b145

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

b1906ab

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

9795062

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

0f83085

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

ee4dd1a

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

53ba0b2

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

a6aee2a

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

33442d4

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

8e6c5c9

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

efd263c

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

ecfda4f

Merge branch 'main' of https://github.com/NVIDIA/NeMo into main

15aee0c

early stop callback for prompt/p tuning

3fe8e34

Signed-off-by: arendu <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

0d2666c

for more information, see https://pre-commit.ci

Merge branch 'main' into adithyare/early_stop_ptuning

1af3e79

update

ecbb118

Signed-off-by: arendu <[email protected]>

Merge branch 'adithyare/early_stop_ptuning' of https://github.com/NVI…

8af4d3e

…DIA/NeMo into adithyare/early_stop_ptuning

Merge branch 'main' into adithyare/early_stop_ptuning

b0d9ea4

Merge branch 'main' into adithyare/early_stop_ptuning

8651935

added exp manager config for early stop

2b569e5

Signed-off-by: arendu <[email protected]>

Merge branch 'adithyare/early_stop_ptuning' of https://github.com/NVI…

d6f48d1

…DIA/NeMo into adithyare/early_stop_ptuning

Merge branch 'main' into adithyare/early_stop_ptuning

409d94e

arendu and others added 12 commits February 19, 2023 13:49

fixed init

ad7216c

Signed-off-by: arendu <[email protected]>

setting lstm params the old way

c2def0f

Signed-off-by: arendu <[email protected]>

revert t5 dataset

7b790ef

Signed-off-by: arendu <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

a26360e

for more information, see https://pre-commit.ci

revert t5 dataset

609af27

Signed-off-by: arendu <[email protected]>

revert t5 dataset

4af7825

Signed-off-by: arendu <[email protected]>

revert t5 dataset

4f83a0b

Signed-off-by: arendu <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

8b1a20f

for more information, see https://pre-commit.ci

revert t5 dataset

1b89180

Signed-off-by: arendu <[email protected]>

Merge branch 'adithyare/refac_ptuning_part2' of https://github.com/NV…

88ec311

…IDIA/NeMo into adithyare/refac_ptuning_part2

save to now works with pp>1

b8e417f

Signed-off-by: arendu <[email protected]>

revert t5 datasets

287e7f7

Signed-off-by: arendu <[email protected]>

unused args

4025a30

Signed-off-by: arendu <[email protected]>

arendu requested a review from Zhilin123 February 21, 2023 22:33

arendu and others added 10 commits February 22, 2023 14:53

Merge branch 'main' into adithyare/refac_ptuning_part2

ca9c4b1

make prompt encoder state_dict backwards compatible

1d7a392

Signed-off-by: arendu <[email protected]>

pipe taskname to prompt encoder

9bf4154

Signed-off-by: arendu <[email protected]>

update

832a847

Signed-off-by: arendu <[email protected]>

update

6a3849d

Signed-off-by: arendu <[email protected]>

Merge branch 'main' into adithyare/refac_ptuning_part3

dd75591

[pre-commit.ci] auto fixes from pre-commit.com hooks

4623a3a

for more information, see https://pre-commit.ci

Merge branch 'adithyare/refac_ptuning_part3' into adithyare/refac_ptu…

30216ee

…ning_part2

comment

c93df19

Signed-off-by: arendu <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

c2b10cb

for more information, see https://pre-commit.ci

Zhilin123 approved these changes Feb 24, 2023

View reviewed changes

arendu merged commit 7b36e62 into main Feb 24, 2023

arendu deleted the adithyare/refac_ptuning_part2 branch February 24, 2023 02:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

P-tuning refactor Part 2/N #6056

P-tuning refactor Part 2/N #6056

arendu commented Feb 18, 2023 •

edited

Loading

arendu commented Feb 20, 2023

Zhilin123 left a comment

P-tuning refactor Part 2/N #6056

P-tuning refactor Part 2/N #6056

Conversation

arendu commented Feb 18, 2023 • edited Loading

What does this PR do ?

Changelog

Usage

Before your PR is "Ready for review"

Who can review?

Additional Information

arendu commented Feb 20, 2023

Zhilin123 left a comment

Choose a reason for hiding this comment

arendu commented Feb 18, 2023 •

edited

Loading