Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr doc tn #6041

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Pr doc tn #6041

merged 4 commits into from
Feb 17, 2023

Conversation

yzhang123
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

yzhang123 and others added 2 commits February 7, 2023 22:54
* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>

* fix links

Signed-off-by: Yang Zhang <[email protected]>

* fix spelling

Signed-off-by: Yang Zhang <[email protected]>

* add warning

Signed-off-by: Yang Zhang <[email protected]>

* add comment

Signed-off-by: Yang Zhang <[email protected]>

---------

Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
@@ -3,6 +3,11 @@
Text (Inverse) Normalization
============================

.. warning::

*TN/ITN is transitioning from [NVIDIA/NeMo](https://github.com/NVIDIA/NeMo) repository to a standalone [NVIDIA/NeMo-text-processing](https://github.com/NVIDIA/NeMo-text-processing) repository. All updates and discussions/issues should go to the new repository.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is transitioning -> transitioned

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

NeMo provides tools to deploy :doc:`TN and ITN <wfst_text_normalization>` for production :cite:`textprocessing-deployment-zhang2021nemo`.
.. warning::

*TN/ITN is transitioning from [NVIDIA/NeMo](https://github.com/NVIDIA/NeMo) repository to a standalone [NVIDIA/NeMo-text-processing](https://github.com/NVIDIA/NeMo-text-processing) repository. All updates and discussions/issues should go to the new repository.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Signed-off-by: Yang Zhang <[email protected]>
@yzhang123
Copy link
Contributor Author

the DCO was not me, so i can't fix it

Copy link
Collaborator

@XuesongYang XuesongYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! left some nit picks.

@XuesongYang XuesongYang merged commit 4f06f34 into main Feb 17, 2023
@XuesongYang XuesongYang deleted the pr_doc_tn branch February 17, 2023 02:05
@XuesongYang
Copy link
Collaborator

the DCO was not me, so i can't fix it

overrided and merged.

titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* Tn doc 16 (NVIDIA#5954)
* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* Tn doc 16 (NVIDIA#5954)
* fix new repo links

Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants