Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] Add Spanish IPA dictionaries and heteronyms #6037

Merged
merged 1 commit into from
Feb 16, 2023
Merged

[TTS] Add Spanish IPA dictionaries and heteronyms #6037

merged 1 commit into from
Feb 16, 2023

Conversation

rlangman
Copy link
Collaborator

@rlangman rlangman commented Feb 16, 2023

What does this PR do ?

Add Spanish pronunciation dictionaries following the same format and naming convention as the German dictionary.

Collection: [TTS]

Changelog

  • Add dictionary and heteronym files for es_ES (Spain Spanish) and es_LA (Latin American Spanish).

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@XuesongYang
Copy link
Collaborator

The dictionary words are all uppercase. Are pronunciations cap-sensitive for Spanish?

heteronym words are all lowercase. I am good with that but just want to confirm if lowercase is on purpose.

@rlangman
Copy link
Collaborator Author

The dictionary words are all uppercase. Are pronunciations cap-sensitive for Spanish?

heteronym words are all lowercase. I am good with that but just want to confirm if lowercase is on purpose.

Pronunciation does not change depending on capitalization, so I have followed the same convention as the English dictionary (dictionary words all capital, heteronym all lowercase).

@XuesongYang
Copy link
Collaborator

The dictionary words are all uppercase. Are pronunciations cap-sensitive for Spanish?
heteronym words are all lowercase. I am good with that but just want to confirm if lowercase is on purpose.

Pronunciation does not change depending on capitalization, so I have followed the same convention as the English dictionary (dictionary words all capital, heteronym all lowercase).

Great! Thank you!

@rlangman rlangman merged commit e23d62b into main Feb 16, 2023
@XuesongYang XuesongYang deleted the es_dict branch February 16, 2023 18:40
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants