Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Customization Dataset Preparation Tool #6029

Merged
merged 7 commits into from
Feb 17, 2023
Merged

Conversation

Zhilin123
Copy link
Collaborator

Allows users to read data into prompt-and-completion format .jsonl as expected by the Customization service/NeMo LLM P tuning service

Signed-off-by: Zhilin Wang [email protected]

What does this PR do ?

Allows users to read data into prompt-and-completion format .jsonl as expected by the Customization service/NeMo LLM P tuning service

Collection: NLP

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

See tutorial.ipynb

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Allows users to read data into prompt-and-completion format .jsonl as expected by the Customization service/NeMo LLM P tuning service

Signed-off-by: Zhilin Wang [email protected]
@Zhilin123 Zhilin123 self-assigned this Feb 15, 2023
Copy link
Member

@okuchaiev okuchaiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add licence headers as well as docstrings to functions

@@ -0,0 +1,151 @@
{
Copy link
Member

@okuchaiev okuchaiev Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added as a subsection here docs/source/nlp/nemo_megatron/prompt_learning.rst ? Also there is no dataset_validation.py file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently set to the run instructions in the header of customization_dataset_preparation.py --> this would be much easier for people to see and read when they use the py file separately (w/o needing to download nemo or going to nemo docs).

Copy link
Member

@okuchaiev okuchaiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Zhilin123 Zhilin123 merged commit 050971b into main Feb 17, 2023
@nithinraok nithinraok deleted the dataset_preparation_tool branch February 17, 2023 22:44
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* Add Customization Dataset Preparation Tool

Allows users to read data into prompt-and-completion format .jsonl as expected by the Customization service/NeMo LLM P tuning service

Signed-off-by: Zhilin Wang [email protected]

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add license and usage examples, remove tutorial

Signed-off-by: Zhilin Wang [email protected]

* Fix typo

Signed-off-by: Zhilin Wang [email protected]

* Fix some more typos

---------

Signed-off-by: Zhilin Wang [email protected]
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Oleksii Kuchaiev <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* Add Customization Dataset Preparation Tool

Allows users to read data into prompt-and-completion format .jsonl as expected by the Customization service/NeMo LLM P tuning service

Signed-off-by: Zhilin Wang [email protected]

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add license and usage examples, remove tutorial

Signed-off-by: Zhilin Wang [email protected]

* Fix typo

Signed-off-by: Zhilin Wang [email protected]

* Fix some more typos

---------

Signed-off-by: Zhilin Wang [email protected]
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Oleksii Kuchaiev <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants