Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reinstall.sh dependencies #6027

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Fix reinstall.sh dependencies #6027

merged 2 commits into from
Feb 15, 2023

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Adds missing dependency for using build to build the nemo pip wheel

Collection: [Core]

Changelog

  • Add missing dependency pytest-runner

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

ericharper
ericharper approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@titu1994 titu1994 merged commit aac473a into NVIDIA:main Feb 15, 2023
@titu1994 titu1994 deleted the fix_requirements branch February 15, 2023 03:40
titu1994 added a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
@titu1994 @ericharper
Fix reinstall.sh dependencies (NVIDIA#6027)
18497b0 
Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titu1994 @ericharper