-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyctcdecode to high level beam search API #6026
Conversation
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
) | ||
|
||
try: | ||
import pyctcdecode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason to import in the function? Seems like BeamSearchDecoderWithLM is imported in the function to avoid circular import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All beam search are imported directly inside of the forward in order to prevent runtime import issue if the library is not installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything particular needed changes at the moment, but probably I could request some feature when I add this to diarization-ASR pipeline.
Sounds good, thanks ! |
* Add pyctcdecode to high level beam search API Signed-off-by: smajumdar <[email protected]> * Remove redundant assignment Signed-off-by: smajumdar <[email protected]> --------- Signed-off-by: smajumdar <[email protected]>
* Add pyctcdecode to high level beam search API Signed-off-by: smajumdar <[email protected]> * Remove redundant assignment Signed-off-by: smajumdar <[email protected]> --------- Signed-off-by: smajumdar <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
What does this PR do ?
Adds PyCTCDecode to high level beam search API
Collection: [ASR]
Changelog
Usage
Before your PR is "Ready for review"
Pre checks:
PR Type: