Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BERT support for overlapping forward compute with distopt communication #6024

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

timmoon10
Copy link
Collaborator

What does this PR do ?

This PR adds experimental support in BERT for the distributed Adam optimizer to overlap its parameter all-gather with the forward compute.

Collection: NLP

Changelog

  • Add BERT support for overlapping forward compute with distopt communication

Usage

Set the optimizer to distributed_fused_adam in the config file:

Configure the optimizer with overlap_param_sync: True.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Pinging @shanmugamr1992.

Additional Information

Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@timmoon10 timmoon10 merged commit d4bea87 into NVIDIA:main Feb 15, 2023
@timmoon10 timmoon10 deleted the dist-adam-bert-overlap-forward branch February 15, 2023 21:26
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants