Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation section for ASR datasets from AIStore #6008

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

anteju
Copy link
Collaborator

@anteju anteju commented Feb 13, 2023

Signed-off-by: Ante Jukić [email protected]

What does this PR do ?

This PR adds a section in ASR/Datasets to describe how to use a dataset from AIStore.

Collection: ASR, Documentation

Changelog

  • Added a section in ASR/Datasets with a description of using a dataset from AIStore

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments, plus it looks great!

docs/source/asr/datasets.rst Show resolved Hide resolved
docs/source/asr/datasets.rst Outdated Show resolved Hide resolved
@anteju anteju marked this pull request as ready for review February 13, 2023 21:39
@anteju anteju requested a review from titu1994 February 13, 2023 21:39
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good !

@titu1994 titu1994 merged commit 49d16f9 into NVIDIA:main Feb 15, 2023
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* Added documentation section for ASR datasets from AIStore

Signed-off-by: Ante Jukić <[email protected]>

* Address review comments

Signed-off-by: Ante Jukić <[email protected]>

---------

Signed-off-by: Ante Jukić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants