Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hybrid transcribe #6003

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

ArtyomZemlyak
Copy link
Contributor

What does this PR do ?

Fix transribe function in EncDecHybridRNNTCTCModel.

Collection: [Note which collection this PR will affect]
ASR

Changelog

  • Add variables for transcribe invocation if use_rnnt_decoder.
  • Change name of variable (logits_len to encoded_len).
  • Change ErrorValue to ValueError in change_decoding_strategy of EncDecHybridRNNTCTCBPEModel.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Artem Zemliak <[email protected]>
@github-actions github-actions bot added the ASR label Feb 13, 2023
Copy link
Collaborator

@VahidooX VahidooX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the bug!

Copy link
Collaborator

@VahidooX VahidooX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VahidooX VahidooX merged commit 6c22356 into NVIDIA:main Feb 13, 2023
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
Signed-off-by: Artem Zemliak <[email protected]>
Co-authored-by: Artem Zemliak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants