Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast conformer configs and doc #5997

Merged

Conversation

github-actions[bot]
Copy link
Contributor

Signed-off-by: Dima Rekesh [email protected]

What does this PR do ?

adds fast conformer config files and docs

Collection: [Note which collection this PR will affect]
ASR

Changelog

  • Add specific line by line info of high level changes in this PR.

docs/source/asr/models.rst (added entry for Fast Conformer)
examples/asr/conf/conformer/fastconformer/fastconformer_ctc_bpe.yaml (created)
examples/asr/conf/conformer/fastconformer/fastconformer_transducer_bpe.yaml (created)

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • [ X] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

* fast conformer configs and doc

Signed-off-by: Dima Rekesh <[email protected]>

* feedback

Signed-off-by: Dima Rekesh <[email protected]>

* adding fast conformer to main README

Signed-off-by: Dima Rekesh <[email protected]>

* path changes

Signed-off-by: Dima Rekesh <[email protected]>

* rewording

Signed-off-by: Dima Rekesh <[email protected]>

* further doc changes

Signed-off-by: Dima Rekesh <[email protected]>

* naming

---------

Signed-off-by: Dima Rekesh <[email protected]>
Co-authored-by: Dima Rekesh <[email protected]>
@titu1994 titu1994 merged commit 8267971 into main Feb 12, 2023
@titu1994 titu1994 deleted the cherry-pick-main-1e864246a7bb949b682c3c81ffec69b369519dce branch February 12, 2023 05:44
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* fast conformer configs and doc



* feedback



* adding fast conformer to main README



* path changes



* rewording



* further doc changes



* naming

---------

Signed-off-by: Dima Rekesh <[email protected]>
Co-authored-by: Dima Rekesh <[email protected]>
Co-authored-by: Dima Rekesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants