Fix bug where GPT always enabled distopt overlapped param sync #5995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmoon10
added
bug
timmoon10
force-pushed
the
dist-adam-overlap-forward-option-bugfix
branch
from
3240a9f
to
0afb078
Compare
…compute Signed-off-by: Tim Moon <[email protected]>
timmoon10
force-pushed
the
dist-adam-overlap-forward-option-bugfix
branch
from
1b0f3d3
to
022f488
Compare
Signed-off-by: Tim Moon <[email protected]>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
…A#5995) * GPT no longer explicitly overlaps distopt communication with forward compute Signed-off-by: Tim Moon <[email protected]> * Remove unused import Signed-off-by: Tim Moon <[email protected]> --------- Signed-off-by: Tim Moon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
With the changes in #5684, I observe that GPT always sets
overlap_param_sync=True. This PR allows the user to manually override that option, which nowFalseby default.Collection: NLP
Changelog
Usage
When using the
distributed_fused_adamoptimizer, setoverlap_param_sync: Truein the optimizer config.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information