[ASR] Convolution-invariant SDR loss + unit tests #5992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anteju
force-pushed
the
dev/cisdr
branch
2 times, most recently
from
db9dbbb
to
c3b0475
Compare
anteju
force-pushed
the
dev/cisdr
branch
2 times, most recently
from
96c453d
to
e21f306
Compare
anteju
force-pushed
the
dev/cisdr
branch
4 times, most recently
from
ebd839e
to
4ee49d0
Compare
jbalam-nv
previously approved these changes
Feb 25, 2023
| if remove_mean: | ||
| estimate = estimate - temporal_mean(estimate, mask=mask, keepdim=True, eps=eps) | ||
| target = target - temporal_mean(target, mask=mask, keepdim=True, eps=eps) | ||
|
|
There was a problem hiding this comment.
Shouldn't we throw an error here if both scale_invariant and convolution_invariant are True?
There was a problem hiding this comment.
You're right, added that.
Signed-off-by: Ante Jukić <[email protected]>
Signed-off-by: Ante Jukić <[email protected]>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
* Added convolution-invariant SDR loss + unit tests Signed-off-by: Ante Jukić <[email protected]> * Addressed comment Signed-off-by: Ante Jukić <[email protected]> --------- Signed-off-by: Ante Jukić <[email protected]>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* Added convolution-invariant SDR loss + unit tests Signed-off-by: Ante Jukić <[email protected]> * Addressed comment Signed-off-by: Ante Jukić <[email protected]> --------- Signed-off-by: Ante Jukić <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR adds a convolution-invariant SDR loss for audio-to-audio tasks.
Reference:
C. Boeddeker et al., Convolutive Transfer Function Invariant SDR training criteria for Multi-Channel Reverberant Speech Separation, 2021
Collection: ASR
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information