Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vits doc #5989

Merged
merged 9 commits into from
Feb 13, 2023
Merged

Vits doc #5989

merged 9 commits into from
Feb 13, 2023

Conversation

treacker
Copy link
Contributor

@treacker treacker commented Feb 10, 2023

What does this PR do ?

Update documentation for VITS

Collection: [TTS]

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the changes to core.c? Isn't that from an external codebase?


VITS
~~~~~~~~~~~~~~~
VITS is an end-to-end speech synthesis model, which generates raw waveform audios from grapheme/phoneme input. It uses Variational Autoencoder to combine GlowTTS-like spectrogram generator with HiFiGAN vocoder model. Also is has separate flow-based duration predictor, which samples alignments from noise with conditioning on text. Please refer to :cite:`tts-models-kim2021conditional` for details.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks:
s/HiFiGAN/HiFi-GAN
s/Also is has separate/Also, it has a separate

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, might be worth mentioning that it is @experimental right now, unless you plan to remove that tag soon.

@@ -0,0 +1,45 @@
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to 2023 now

nemo/collections/tts/modules/monotonic_align/setup.py Outdated Show resolved Hide resolved
Signed-off-by: Evgeniy Shabalin <[email protected]>
Signed-off-by: Evgeniy Shabalin <[email protected]>
Signed-off-by: Evgeniy Shabalin <[email protected]>
Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@redoctopus redoctopus merged commit a7c2a04 into main Feb 13, 2023
@redoctopus redoctopus deleted the vits_doc branch February 13, 2023 21:07
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* storing

* Added VITS documentation

Signed-off-by: Evgeniy Shabalin <[email protected]>

* Added VITS documentation

Signed-off-by: Evgeniy Shabalin <[email protected]>

* Cleaned stuff

Signed-off-by: Evgeniy Shabalin <[email protected]>

* Cleaned stuff

Signed-off-by: Evgeniy Shabalin <[email protected]>

* cleaning

Signed-off-by: Evgeniy Shabalin <[email protected]>

* Typos

Signed-off-by: Evgeniy Shabalin <[email protected]>

* Added experimental note

Signed-off-by: Evgeniy Shabalin <[email protected]>

---------

Signed-off-by: Evgeniy Shabalin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants