Refactor the retrieval services for microservice architecture #5910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nemo/collections/nlp/modules/common/megatron/retrieval_services/retrieval_service.py
Fixed
Show fixed
Hide fixed
| weights = weights / weights.sum() | ||
| self.weight_container[0] = weights | ||
|
|
||
| def put(self): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns
nemo/collections/nlp/modules/common/megatron/retrieval_services/combo_retrieval_server.py
Fixed
Show fixed
Hide fixed
nemo/collections/nlp/modules/common/megatron/retrieval_services/combo_retrieval_server.py
Fixed
Show fixed
Hide fixed
nemo/collections/nlp/modules/common/megatron/retrieval_services/combo_retrieval_server.py
Fixed
Show fixed
Hide fixed
nemo/collections/nlp/modules/common/megatron/retrieval_services/combo_retrieval_server.py
Fixed
Show fixed
Hide fixed
nemo/collections/nlp/modules/common/megatron/retrieval_services/combo_retrieval_server.py
Fixed
Show fixed
Hide fixed
| try: | ||
| from apex.transformer import parallel_state | ||
|
|
||
| HAVE_APEX = True |
Check notice
Code scanning / CodeQL
Unused global variable
|
|
||
| HAVE_APEX = True | ||
| except (ImportError, ModuleNotFoundError): | ||
| HAVE_APEX = False |
Check notice
Code scanning / CodeQL
Unused global variable
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
…#5910) * retrieval service seperation Signed-off-by: Yi Dong <[email protected]> * refactor service code Signed-off-by: Yi Dong <[email protected]> * fix name Signed-off-by: Yi Dong <[email protected]> * add combo server Signed-off-by: Yi Dong <[email protected]> * added combo files Signed-off-by: Yi Dong <[email protected]> * fix the bug Signed-off-by: Yi Dong <[email protected]> * add retrieval service Signed-off-by: Yi Dong <[email protected]> * fix updatable flag Signed-off-by: Yi Dong <[email protected]> * working example Signed-off-by: Yi Dong <[email protected]> * seperate text generation server Signed-off-by: Yi Dong <[email protected]> * added webserver Signed-off-by: Yi Dong <[email protected]> * clean up and fix zero neighbor issue Signed-off-by: Yi Dong <[email protected]> * fix the style Signed-off-by: Yi Dong <[email protected]> * add license Signed-off-by: Yi Dong <[email protected]> * fixed code QL Signed-off-by: Yi Dong <[email protected]> * added bash script to launch the demo Signed-off-by: Yi Dong <[email protected]> * clean up Signed-off-by: Yi Dong <[email protected]> --------- Signed-off-by: Yi Dong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Refactor the retrieval services so each component can be deployed alone inside a container. This allows it to be served easily in a cloud. Also fixed some issues with zero neighbor retrieval.